Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: source map generation #901

Merged
merged 1 commit into from
Mar 6, 2019
Merged

fix: source map generation #901

merged 1 commit into from
Mar 6, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #652

partial #886

Breaking Changes

No

Additional Info

Avoid prefix, because postcss generate invalid source map, also normalize path in source map from other loader (node-sass generate forward slash in source map, but it is invalid because source map using URLs, paths are invalid)

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #901 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #901      +/-   ##
==========================================
- Coverage   99.25%   99.25%   -0.01%     
==========================================
  Files          10       10              
  Lines         402      401       -1     
  Branches      118      119       +1     
==========================================
- Hits          399      398       -1     
  Misses          3        3
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49e904...7222d83. Read the comment docs.

@alexander-akait alexander-akait merged commit e9ce745 into master Mar 6, 2019
@alexander-akait alexander-akait deleted the issue-652 branch March 6, 2019 14:48
This was referenced Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird source map paths when used together with sass-loader
1 participant