Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sourcemap generating when previous loader pass sourcemap as string #905

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Previously we stringify string, it is invalid. No test, because we already have test on this

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #905 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #905   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          10       10           
  Lines         396      396           
  Branches      118      118           
=======================================
  Hits          393      393           
  Misses          3        3
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc81af1...4a22a1c. Read the comment docs.

@alexander-akait alexander-akait merged commit 3797e4d into master Mar 6, 2019
@alexander-akait alexander-akait deleted the fix-source-map-is-string branch March 6, 2019 17:13
This was referenced Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant