refactor: better export escaped locals #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
==========================================
- Coverage 99.25% 99.24% -0.02%
==========================================
Files 10 10
Lines 401 395 -6
Branches 119 119
==========================================
- Hits 398 392 -6
Misses 3 3
Continue to review full report at Codecov.
|
fa93hws
reviewed
Jul 14, 2019
| options | ||
| ); | ||
|
|
||
| return normalizeIdentifier(hash); |
There was a problem hiding this comment.
This line makes the replacing the / in path to - no longer working.
Is that on purpose?
This was referenced Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Better export locals for escaping selectors
Breaking Changes
In theory yes becase it is change css output for classes and ids but previously implementation was wrong so it is bugfix
Additional Info
No