feat: modules options now accepts object config #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
feat-modules-accept-object-config
branch
from
7545541
to
984fff6
Compare
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
==========================================
+ Coverage 99.26% 99.27% +<.01%
==========================================
Files 10 10
Lines 408 411 +3
Branches 121 121
==========================================
+ Hits 405 408 +3
Misses 3 3
Continue to review full report at Codecov.
|
BREAKING CHANGE: - `localIdentName` option was removed in favor `modules.localIdentName` option - `context` option was remove in favor `modules.context` option - `hashPrefix` option was removed in favor `modules.hashPrefix` option - `getLocalIdent` option was removed in favor `modules.getLocalIdent` option - `localIdentRegExp` option was removed in favor `modules.localIdentRegExp` option
alexander-akait
force-pushed
the
feat-modules-accept-object-config
branch
from
984fff6
to
6231f35
Compare
This was referenced Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Move all CSS modules options in
modulesoption.Breaking Changes
Yes
BREAKING CHANGES:
localIdentNameoption was removed in favormodules.localIdentNameoptioncontextoption was remove in favormodules.contextoptionhashPrefixoption was removed in favormodules.hashPrefixoptiongetLocalIdentoption was removed in favormodules.getLocalIdentoptionlocalIdentRegExpoption was removed in favormodules.localIdentRegExpoptionAdditional Info
No