fix: invert Function behavior for url and import options
#939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: you should return `true` when you want handle `url`/`@import` and return `false` if not
Codecov Report
@@ Coverage Diff @@
## master #939 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 10 10
Lines 412 412
Branches 122 122
=======================================
Hits 409 409
Misses 3 3
Continue to review full report at Codecov.
|
This was referenced Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #891
Breaking Changes
Yes
BREAKING CHANGE: you should return
truewhen you want handleurl/@importand returnfalseif notAdditional Info
No