Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support regex in filter #1555

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

janlent1
Copy link
Contributor

Makes running css-loader with advanced filter settings in worker possible.

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

For thread-loader, setting functions as options is not allowed yet, but regex is. Therefore, supporting regex as a filter option for css-loader enables us to use the loader parallelized.

Breaking Changes

Additional Info

Makes running css-loader with advanced filter settings in worker possible.
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (797042c) 95.78% compared to head (4ca3a75) 95.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1555   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files          10       10           
  Lines        1185     1187    +2     
  Branches      456      457    +1     
=======================================
+ Hits         1135     1137    +2     
  Misses         41       41           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant