Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

Eslint loader checks for files in node_modules symlinked repository #165

Closed
adamborowski opened this issue Mar 21, 2017 · 2 comments
Closed

Comments

@adamborowski
Copy link

adamborowski commented Mar 21, 2017

I use https://lernajs.io/ to link local packages I develop simultaneously.
I get eslint loader error on module [0] which is symlinked and the link is under node_modules folder.
This module shouldn't be linted because it is compiled /minified code on purpose.
Webpack seems to resolve symlinks immediately so it treats it as a regular source code to lint...

explorejs-lib.min.js  95.1 kB       0  [emitted]  main
[0] ../explorejs-common/lib/explorejs-common.js 221 kB {0} [built] [1 error]
[1] ./src/data/DataRequest.js 2.05 kB {0} [built]
[5] (webpack)/buildin/module.js 517 bytes {0} [built]
[6] ./src/adapter/DygraphsAdapter.js 3.81 kB {0} [built]
[7] ./src/modules/CacheManager.js 4.69 kB {0} [built]
[8] ./src/modules/RequestManager.js 7.05 kB {0} [built]
[9] ./src/prediction/index.js 713 bytes {0} [built]
[12] ./src/modules/DataSource.js 6.41 kB {0} [built]
[13] ./src/modules/DynamicProjection.js 5.81 kB {0} [built]
[16] ./src/modules/SerieCache.js 7.25 kB {0} [built]
[19] ./src/modules/WrapperIdFactory.js 2.17 kB {0} [built]
[20] ./src/modules/batch/MergingBatch.js 8.72 kB {0} [built]
[21] ./src/prediction/BasicViewportModel.js 3.27 kB {0} [built]
[22] ./src/prediction/WiderContextModel.js 3.72 kB {0} [built]
[25] ./src/index.js 1.18 kB {0} [built]

my webpack config for loader is configured to exclude node_modules

{
        test: /(\.jsx|\.js)$/,
        loader: 'eslint-loader',
        exclude: /node_modules/
}

How to deal with this case? Should it behave like that or it's a bug in webpack/eslintloader?

@MoOx
Copy link
Contributor

MoOx commented Mar 23, 2017

It's looks like a webpack issue more than an eslint one.

@adamborowski
Copy link
Author

Yeah, you are right:
webpack/webpack#943

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants