-
-
Notifications
You must be signed in to change notification settings - Fork 121
fix module build failed error at Linter.parseResults #294
fix module build failed error at Linter.parseResults #294
Conversation
Khoa Bui Hoang Dang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Codecov Report
@@ Coverage Diff @@
## master #294 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 7
Lines 133 134 +1
Branches 27 28 +1
=====================================
+ Hits 133 134 +1
Continue to review full report at Codecov.
|
@buihdk fix messages of commits, CI is not passing.
try:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests?
update based on conversation
Do you want end-to-end tests or just unit tests i.e. I'll add a |
@buihdk unit tests enough |
@evilebottnawi I don't have permission to merge 😞 |
@ricardogobbosouza strange, you have |
@evilebottnawi |
@ricardogobbosouza let's investigate this situation, i want to add permissions on merge and release |
@ricardogobbosouza Can you check again? |
/cc @ricardogobbosouza can you give npm username? |
@evilebottnawi sure, its same ricardogobbosouza |
@ricardogobbosouza please enable 2FA |
@evilebottnawi enabled |
@ricardogobbosouza now you can do release:
|
@evilebottnawi thanks |
@evilebottnawi @ricardogobbosouza hey man! how is it going with releasing bugfix? P.S. I will appreciate your new release with this fix. 🙏 Actually need your attention at the moment |
@misha-panyushkin near future |
This PR contains a:
Motivation / Use-Case
I am using the latest eslint-loader v3.0.0 on my rejected create-react-app and encountered this issue when I tried to start the app:
TypeError: Cannot read property 'forEach' of undefined
. This is the fix for this error.