refactor: reduce runtime code

webpack-contrib · Jul 25, 2024 · 142ac35 · 142ac35
1 parent c3faac4
commit 142ac35
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 31 deletions.
diff --git a/src/plugins/sources-plugin.js b/src/plugins/sources-plugin.js
@@ -139,8 +139,7 @@ export default (options) =>
     let offset = 0;
 
     for (const source of sources) {
-      const { name, value, isValueQuoted, runtime, startOffset, endOffset } =
-        source;
+      const { name, value, isValueQuoted, startOffset, endOffset } = source;
 
       let request = value;
 
@@ -180,7 +179,6 @@ export default (options) =>
           importName,
           hash,
           isValueQuoted,
-          runtime,
         });
       }
 

diff --git a/src/utils.js b/src/utils.js
@@ -1268,37 +1268,28 @@ export function getModuleCode(html, replacements, loaderContext, options) {
   let needHelperImport = false;
 
   for (const item of replacements) {
-    const { runtime, importName, replacementName, isValueQuoted, hash } = item;
-
-    if (typeof runtime === "undefined" || runtime === true) {
-      const getUrlOptions = []
-        .concat(hash ? [`hash: ${JSON.stringify(hash)}`] : [])
-        .concat(isValueQuoted ? [] : "maybeNeedQuotes: true");
-      const preparedOptions =
-        getUrlOptions.length > 0 ? `, { ${getUrlOptions.join(", ")} }` : "";
-
-      const needHelperFn = getUrlOptions.length > 0;
-
-      if (needHelperFn) {
-        if (!needHelperImport) {
-          needHelperImport = true;
-        }
-
-        replacersCode += `var ${replacementName} = ${GET_SOURCE_FROM_IMPORT_NAME}(${importName}${preparedOptions});\n`;
+    const { importName, replacementName, isValueQuoted, hash } = item;
+    const getUrlOptions = []
+      .concat(hash ? [`hash: ${JSON.stringify(hash)}`] : [])
+      .concat(isValueQuoted ? [] : "maybeNeedQuotes: true");
+    const preparedOptions =
+      getUrlOptions.length > 0 ? `, { ${getUrlOptions.join(", ")} }` : "";
+
+    const needHelperFn = getUrlOptions.length > 0;
+
+    if (needHelperFn) {
+      if (!needHelperImport) {
+        needHelperImport = true;
       }
 
-      const name = needHelperFn ? replacementName : importName;
-
-      code = code.replace(new RegExp(replacementName, "g"), () =>
-        isTemplateLiteralSupported ? `\${${name}}` : `" + ${name} + "`,
-      );
-    } else {
-      code = code.replace(new RegExp(replacementName, "g"), () =>
-        isTemplateLiteralSupported
-          ? `\${${replacementName}}`
-          : `" + ${replacementName} + "`,
-      );
+      replacersCode += `var ${replacementName} = ${GET_SOURCE_FROM_IMPORT_NAME}(${importName}${preparedOptions});\n`;
     }
+
+    const name = needHelperFn ? replacementName : importName;
+
+    code = code.replace(new RegExp(replacementName, "g"), () =>
+      isTemplateLiteralSupported ? `\${${name}}` : `" + ${name} + "`,
+    );
   }
 
   // Replaces "<script>" or "</script>" to "<" + "script>" or "<" + "/script>".