feat: add possibility to extend default minimize options #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 92.15% 92.16% +0.01%
==========================================
Files 7 7
Lines 586 587 +1
Branches 188 188
==========================================
+ Hits 540 541 +1
Misses 37 37
Partials 9 9
Continue to review full report at Codecov.
|
| @@ -496,7 +496,7 @@ function isProductionMode(loaderContext) { | |||
| return loaderContext.mode === "production" || !loaderContext.mode; | |||
| } | |||
|
|
|||
| const defaultMinimizerOptions = { | |||
| export const defaultMinimizerOptions = { | |||
There was a problem hiding this comment.
Let's reexport it in index.js, we should avoid using html-loader/dist/utils, because structure can be changed, better to use require('html-loader').defaultMinimizerOptions
There was a problem hiding this comment.
reexported + fixed docs
fretfan
force-pushed
the
feat-export-default-minimize-options
branch
from
c1ba176
to
7e14f72
Compare
alexander-akait
approved these changes
Jan 6, 2022
|
Can you accept CLA? |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Closes #413