feat: add custom parameter names for wrapper args #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 183 189 +6
Branches 67 68 +1
=========================================
+ Hits 183 189 +6
Continue to review full report at Codecov.
|
|
Hi @evilebottnawi . Updated the README. |
| @@ -1169,7 +1169,7 @@ exports[`loader should work with the "wrapper" options as an object notation: er | |||
| exports[`loader should work with the "wrapper" options as an object notation: module 1`] = ` | |||
| "/*** IMPORTS FROM imports-loader ***/ | |||
|
|
|||
| (function(myGlobalVariable, myOtherGlobalVariable) { | |||
| (function() { | |||
There was a problem hiding this comment.
Why it was changed? We should not change other tests, otherwise it is the breaking change
There was a problem hiding this comment.
Fixed it. It was a bug. 😅
anuragkalia
force-pushed
the
feat-wrapper-args-custom-names
branch
from
8cccb11
to
86162a7
Compare
| @@ -56,19 +56,29 @@ export default function loader(content, sourceMap) { | |||
| if (typeof options.wrapper !== 'undefined') { | |||
| let thisArg; | |||
| let args; | |||
| let params; | |||
There was a problem hiding this comment.
let params = '';
And remove params = ''; from boolean/string
alexander-akait
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
I wanted to create a wrapper like this: https://github.com/google/shaka-player/blob/master/build/wrapper.template.js where it should be possible for me where arguments and parameters have different names.
The current loader is perfect for the use case: it has hook for
additionalCodeas well aswrapper. This PR adds the only missing functionality: differing names.Breaking Changes
None.
Additional Info
None.