Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules installed on parent are not seen #32

Closed
TCMiranda opened this issue Mar 9, 2016 · 3 comments · Fixed by dmitriz/npm-install-webpack-plugin#2
Closed

Modules installed on parent are not seen #32

TCMiranda opened this issue Mar 9, 2016 · 3 comments · Fixed by dmitriz/npm-install-webpack-plugin#2

Comments

@TCMiranda
Copy link

Hey guys! Great tool thanks!

Unfortunately I have a breaking issue, that some of my development modules are defined on the parent package.json, and the tool started to install them in my child module assuming they were not installed.

I didn't had the chance to check how it works, but using require.resolve(module) shouldn't fix this?

Thanks!!!!

@ericclemmons
Copy link
Member

Version & example please!

There should be one package.json for the project in the context that webpack is running (literally, context, which defaults to process.cwd()).

It must mean that webpack is having an issue resolving it, because I'm no longer using require.resolve, since it's not 100% how Webpack works.

@FiberJW
Copy link

FiberJW commented Mar 16, 2016

@ericclemmons
Copy link
Member

Closing as this seems to be a misunderstanding of how the project works.

It's for installing dependencies in the scope of the current project that's missing.

Let me know if I misunderstood...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants