Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add dynamic imports to main bundle #384

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

daKmoR
Copy link
Collaborator

@daKmoR daKmoR commented Dec 17, 2018

In order to support dynamic imports we add all their contents to
the main bundle as well.

This PR contains a:

  • bugfix

Motivation / Use-Case

If you use import('./foo.js').then() webpack will by default create different chunks.
As they are not auto served by karma we add the dynamic content to the main bundle as well.

In order to support dynamic imports we add all their contents to
the main bundle as well.
@matthieu-foucault
Copy link
Collaborator

For future reference, can you use the Angular format (and/or use commitizen) for your commits?
This allows automated generation of changelogs.

You're just missing the scope (which would be karma-webpack, although we could be more precise if need be)

@matthieu-foucault matthieu-foucault merged commit 288a8c2 into codymikol:next Dec 19, 2018
@daKmoR
Copy link
Collaborator Author

daKmoR commented Dec 19, 2018

oh I'm more used to have scopes for mono repos... e.g. each package having it's own scope.

As karma-webpack is a single package - which scopes would we use? is there a list?

@matthieu-foucault
Copy link
Collaborator

There is no list as far as I'm aware. Looking at the commit history, those have been used pretty inconsistently as far as I can tell.

Maybe using the name of the file most affected by the change, or the class/object name.
For instance, if we want to easily track changes to the default webpack options, then defaultWebpackOptions could be a scope.
I don't have strong opinions on this, it's mostly a matter of formatting the changelog (and looking at it, it does seem that it works without a scope)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants