fix(karma-webpack): don't error when webpackMiddleware config not provided #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Perfect thanks! |
ryanclark
approved these changes
Jun 7, 2019
ryanclark
changed the title
6 tasks
|
Seems to be stuck on the CLA check, @evilebottnawi any ideas? |
|
Sometimes it is buggy, just reopen issue |
|
Nice one! |
Den-dp
added a commit
to Den-dp/DefinitelyTyped
that referenced
this pull request
Jul 2, 2024
Den-dp
added a commit
to Den-dp/DefinitelyTyped
that referenced
this pull request
Jul 2, 2024
8 tasks
Den-dp
added a commit
to Den-dp/DefinitelyTyped
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Error is thrown if no
webpackMiddleware. You can see here the change that makes the CI pass again.Breaking Changes
N/A
Additional Info
Regression introduced in 4.0.0