fix(package): add webpack >= v4.0.0 (peerDependencies)
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
changed the title
webpack >= v4.0.0 (peerDependencies)
michael-ciniawsky
requested changes
Feb 27, 2018
test/helpers/compile.js
Outdated
| @@ -10,6 +10,7 @@ function compile(fixture, moduleRules, resolveAlias = {}) { | |||
|
|
|||
| webpack({ | |||
| entry, | |||
| mode: 'development', | |||
There was a problem hiding this comment.
Please drop this as the test setup needs additional changes to work with webpack >= v4.0.0 (CommonChunksPlugin removed etc etc) :) This will be taken care of by #233 separately
|
So the |
michael-ciniawsky
approved these changes
Feb 27, 2018
|
Thx |
|
Released in |
This was referenced Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds webpack 4 as an allowed peer dependency
Had to fix the dev dependency of webpack to
^3.10.0(matches uglify plugin) otherwise the tests would use latest and fail asmodewas not set in the config.