feat(hmr): adding hot module reloading #334
Conversation
Initial implementation copied over from extract-css-chunks-webpack-plugin Adding Eslint config for loaders that are injected directly into the browser. These should remain ES5
…odule-reloading # Conflicts: # package-lock.json
|
@evilebottnawi ill slack you tomorrow to discuss this further in detail. |
- Remove `this.cacheable` from hotLoader function - Remove `isHMR`, simplifying codebase - Adding `.idea` to gitignore. This prevents JetBrains products config files
Migration of hotLoader from its own file, which is injected into webpack config. Into the base loader of mini-css, instead of adding options to the plugin. Add options to the loader.
|
Still need to test this further, but have been able to simplify it to pass most options via loader options. Testing filename output.. |
|
@ScriptedAlchemy you can looks how we can tests loader in other repositories (example in |
String replace based on filename coming in
updating js hash and adding hmr test cases
ScriptedAlchemy
force-pushed
the
hot-module-reloading
branch
from
04b79ef
to
1700774
Compare
ScriptedAlchemy
force-pushed
the
hot-module-reloading
branch
3 times, most recently
from
a0f62dd
to
923342c
Compare
ScriptedAlchemy
force-pushed
the
hot-module-reloading
branch
from
923342c
to
4c0c742
Compare
removing hot loader to fix tests
using version 3 of normalize-url for node 6 compatibility
ScriptedAlchemy
force-pushed
the
hot-module-reloading
branch
from
201bb78
to
86134d0
Compare
|
@evilebottnawi im getting an error on canery
Got any ideas? its passing everything else |
Adding es-checker to prevent any es6 in the hot loader
ScriptedAlchemy
force-pushed
the
hot-module-reloading
branch
from
13950aa
to
3979add
Compare
|
@evilebottnawi, ive gotten it to pass almost every test, but it seems to fail at |
|
@ScriptedAlchemy don't see on |
# Conflicts: # README.md # package-lock.json # src/loader.js
|
@evilebottnawi I've updated the branch |
|
@ScriptedAlchemy Thanks |
|
Today i fix CI problem, update deps and boilerplate for plugin and do release |
|
when can we expect a version bump + npm publish for this feature? just waiting on that to migrate our implementation to this! thanks again |
|
There’s a few things being finalized in another branch. Mostly chores needed for the project |
|
is there a reason to use thanks for your hard work! 😄 |
|
|
|
/cc @ScriptedAlchemy we should solve this in next PR |
|
@evilebottnawi thanks for the explanation, i'll try to PR if i have the time! |
|
It uses ES6 stuff that causes problem on older node versions @zackschuster |
This PR contains a:
Motivation / Use-Case
Initial implementation copied over from extract-css-chunks-webpack-plugin
Adding Eslint config for loaders that are injected directly into the browser.
These should remain ES5
Breaking Changes
Additional Info
This is a work in progress, looking for feedback on how to implement the HMR part in a better way.
Once the is discussed, ill write the readme and commit it to this branch
This is the unification process of my work on extract-css-chunks