-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(options): use filename mutated after instantiation #430
fix(options): use filename mutated after instantiation #430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That LGTM
/CC @evilebottnawi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, i am recommend don't do this, due webpack@5 will have built-in cache and using this approach is not good idea
This PR contains a:
Motivation / Use-Case
A minor update from 0.6.0 to 0.7.0 broke my webpacker configuration. :(
In 13e9cbf (#381) the
moduleFilename
function was added. This change broke webpacker configurations that set a non-defaultfilename
option.To explain further, if you view the webpacker plugins docs, options can be mutated after construction.
Excerpt from docs:
So, previously, I could set a filename like so:
but after 13e9cbf this was broken and instead you must set
moduleFilename: () => yourFilename
to fix it.Breaking Changes
None
Additional Info