Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new esModule option #475

Merged
merged 1 commit into from
Dec 20, 2019
Merged

feat: new esModule option #475

merged 1 commit into from
Dec 20, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #424 fixes #433

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #475 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #475      +/-   ##
=========================================
+ Coverage   88.67%   88.7%   +0.02%     
=========================================
  Files           5       5              
  Lines         424     425       +1     
  Branches       93      94       +1     
=========================================
+ Hits          376     377       +1     
  Misses         46      46              
  Partials        2       2
Impacted Files Coverage Δ
src/loader.js 89.24% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e1613...dd67282. Read the comment docs.

@Cryrivers
Copy link

Cryrivers commented Jan 2, 2020

should the semantic equivalence to module.exports = {...} be export const XXX = YYY one-by-one instead of export default {...}, and it might be also better for tree-shaking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a configuration flag to enable ES module syntax
2 participants