Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a noRuntime option #831

Merged
merged 1 commit into from
Sep 11, 2021

Conversation

cbazureau
Copy link
Contributor

@cbazureau cbazureau commented Sep 10, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

As seen here webpack-contrib/css-loader#1362 and here #711 i've added a noRuntime option to avoid the runtime generation. Assets are still extracted and can be used for a custom loading methods.
Another PR (#807) tried to do something similar but does others things and will need a rebase. In comparaison i'm using a more minimal approach and add unit tests that shown that :

  • link tags are not generated when noRuntime is true
  • runtime is also not generated in this case

Breaking Changes

None

Additional Info

None

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 10, 2021

CLA Signed

The committers are authorized under a signed CLA.

feat: add a noRuntime option
@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #831 (3a68a3e) into master (e67af52) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #831   +/-   ##
=======================================
  Coverage   92.80%   92.81%           
=======================================
  Files           6        6           
  Lines         723      724    +1     
  Branches      176      177    +1     
=======================================
+ Hits          671      672    +1     
  Misses         49       49           
  Partials        3        3           
Impacted Files Coverage Δ
src/index.js 96.39% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e67af52...3a68a3e. Read the comment docs.

@alexander-akait alexander-akait merged commit 5cc73e6 into webpack-contrib:master Sep 11, 2021
@alexander-akait
Copy link
Member

@cbazureau #832, just rename to runtime: boolean (default true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants