Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heads up: the Sass legacy JS API will start emitting warnings soon #1210

Closed
nex3 opened this issue Jul 19, 2024 · 4 comments · Fixed by #1211 or #1220
Closed

Heads up: the Sass legacy JS API will start emitting warnings soon #1210

nex3 opened this issue Jul 19, 2024 · 4 comments · Fixed by #1211 or #1220

Comments

@nex3
Copy link
Contributor

nex3 commented Jul 19, 2024

The Sass team is planning to release a version of Sass soon that begins to emit deprecation warnings for uses of the legacy JS API. Since this is currently the default for Next.js, it might be a good idea to move to using the modern API as the default instead.
@alexander-akait alexander-akait mentioned this issue Jul 23, 2024
Merged
6 tasks
@G-Rath
Copy link
Contributor

G-Rath commented Jul 23, 2024

@alexander-akait I'm not sure that this was resolved by #1211 as that was only meant to change the load order? I can only find a bunch of checks for the api being modern, but nowhere where the value actually defaults.

@alexander-akait
Copy link
Member

I see, yeah

@alexander-akait
Copy link
Member

Looks like I was very fast and we need a new major release 😄

@xavierfoucrier
Copy link

@alexander-akait I would say "as usual" IMHO 😅☕✌️

@alexander-akait alexander-akait mentioned this issue Jul 25, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nex3 @xavierfoucrier @G-Rath @alexander-akait