Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document deprecation of indentedSyntax option #1240

Closed
2 of 4 tasks
lorefnon opened this issue Oct 20, 2024 · 2 comments · Fixed by #1242
Closed
2 of 4 tasks

Document deprecation of indentedSyntax option #1240

lorefnon opened this issue Oct 20, 2024 · 2 comments · Fixed by #1242

Comments

@lorefnon
Copy link

Documentation Is:

  • Missing
  • Needed
  • Confusing
  • Not Sure?

Please Explain in Detail...

As of this commit, passing sassOptions: { indentedSyntax: true } does nothing and instead we must pass sassOptions: { syntax: "indented" } to use indented syntax.

This breaks configurations that were relying on previous config and this is not documented anywhere.

This is particularly an issue for users of vue-loader because the file extension based autodetection does not work for embedded <style lang="sass">...</style> tags.

Your Proposal for Changes

  • Please add the breaking change in CHANGELOG
  • Document the syntax option in README

If a contributor is abel to confirm that this change was intentional, I can send a PR for the above.

@alexander-akait
Copy link
Member

@lorefnon
Copy link
Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants