Regression in 0.3.0

[appsforartists]

I just tried upgrading to 0.3.0 and got this error in code that works in 0.2.0:

./~/css-loader!./~/autoprefixer-loader!./~/sass-loader!./application/styles.scss
Module build failed: TypeError: undefined is not a function
    at resolveSassPath (node_modules/sass-loader/node_modules/sass-graph/sass-graph.js:24:23)
    at Graph.addFile (node_modules/sass-loader/node_modules/sass-graph/sass-graph.js:66:20)
    at Graph.addFile (node_modules/sass-loader/node_modules/sass-graph/sass-graph.js:72:12)
    at Graph.addFile (node_modules/sass-loader/node_modules/sass-graph/sass-graph.js:72:12)
    at Object.module.exports.parseFile (node_modules/sass-loader/node_modules/sass-graph/sass-graph.js:122:9)
    at Object.module.exports (node_modules/sass-loader/index.js:33:27)
 @ ./application/styles.scss 3:1-339 8:9-347

[akiran]

@appsforartists
I am trying to debug this issue
Can you post the format of your import statements ?

[waldreiter]

I guess there are lots of imports that break.

We have in production a src/_vars.scss that gets included from src/components/List.scss
with the path from the project root:

@import "src/vars.scss";

Another import that crashes in 0.3.0 is:

@import "a.scss", "b.scss";

The last example compiles fine, but it won't get found by sass-graph, because of an extra space:

@import  "a.scss";

[akiran]

I fixed sass-graph and sass-loader to support different formats of importing
Try this https://github.com/akiran/sass-loader.git by installing from git and let me know if it works for you

[waldreiter]

@akiran That was fast. 😃 I have only checked my first example, because this is what we actually use. But it still does not work. It seem like adding this.options.context to loadPathsfixes this case. I wonder why it works with node-sass?

[akiran]

@cody
Can you point me the code snippet of your fix ?

In your first example, you are using absolute paths. You have to add src directory in include paths of webpack config file or use relative paths.
loader: "style!css!sass?includePaths[]=" + srcPath

I tested with different formats of imports
https://github.com/akiran/sass-graph/blob/master/test/test.parse-imports.js
You other examples are taken care in these testcases.

[waldreiter]

@akiran That works. 👍

Just the error message that was given shoud be improved. I got this:

/app/node_modules/sass-loader/node_modules/sass-graph/sass-graph.js:26
  throw "Failed to resolve " + path + " in [" + loadPaths + "]";
                                                          ^
Failed to resolve [object Object] in [/app/src,,/app/src]

@appsforartists Can you check if your bug is fixed too?

[akiran]

This issue is fixed in sass-loader 0.3.1

[appsforartists]

I was able to upgrade to 0.3.1, though I also had to explicitly install node-sass 1.2.2. 1.2.3 throws a "module did not self-register".