-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(README): add example install instructions for dependencies #517
Conversation
When running the examples in the code an error is thrown that `style-loader` and `css-loader` are missing.
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 6 6
Lines 117 117
=======================================
Hits 114 114
Misses 3 3 Continue to review full report at Codecov.
|
@w3apps why? you can you other loader for css instead standard |
I know you can use other loaders. However, my change is strictly where the example uses those specific loaders. See attached image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the examples specifically require loaders, we should add them as devDependencies
to simplify the DX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@w3apps Thx
When running the examples in the code an error is thrown that
style-loader
andcss-loader
are missing.