-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing functions
option as function
#651
Allow passing functions
option as function
#651
Conversation
functions
option as function
53b60cb
to
f4ac3db
Compare
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
==========================================
+ Coverage 98% 98.02% +0.02%
==========================================
Files 6 6
Lines 150 152 +2
==========================================
+ Hits 147 149 +2
Misses 3 3
Continue to review full report at Codecov.
|
Allows the `functions` option for node-sass or dart-sass to be a function, in which case it will be passed the Loader Context as argument
Adds a test for the case where the functions option is supplied as a function. Passes the Loader Context and also checks that it is available.
f4ac3db
to
fc6c195
Compare
I've tried to follow all the guidelines but I don't know how to make the travis build pass here, it's failing with "Invalid revision range" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange error on CI, don't worry looks good, we will release this in next version, thanks
This PR contains a:
Motivation / Use-Case
This PR adds support for supplying the
functions
option as a function of the Loader Context. This corresponds to part of the issue I filed here.Breaking Changes
None. Added a test similar to the one for the "
data
as function"; it passes.