fix: support node-sass v5.0.0 #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
New projects with node-sass are returning an error due to latest being bumped to v5 `Error: Node Sass version 5.0.0 is incompatible with ^4.0.0.`
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 4 4
Lines 226 226
Branches 72 72
=======================================
Hits 217 217
Misses 8 8
Partials 1 1
Continue to review full report at Codecov.
|
|
Fixes #898 |
Lotti
approved these changes
Nov 1, 2020
1 task
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 9, 2020
`node-sass` v5 introduced support for Node.js v15, which is not supported by v4. However, Next.js currently errors with ``` Error: Node Sass version 5.0.0 is incompatible with ^4.0.0. ``` when attempting to build with `node-sass` 5.0.0. This error comes from `sass-loader`. They have recently released version 10.0.5 which supports `node-sass` 5.0.0 (PR <webpack-contrib/sass-loader#899>, release <https://github.com/webpack-contrib/sass-loader/releases/tag/v10.0.5>).
5 tasks
This was referenced Mar 15, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New projects with node-sass are returning an error due to latest being bumped to v5
Error: Node Sass version 5.0.0 is incompatible with ^4.0.0.This PR contains a:
Motivation / Use-Case
Every new (or updated) project using node-sass latest version will result in compilation errors during to mismatch semver.
Breaking Changes
Supports >4.0.0, open to changes.
Additional Info
None