This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
fix: IE =< 8 incompatibility regression #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
michael-ciniawsky
suggested changes
Sep 28, 2017
addScript.js
Outdated
| eval.call(null, src); | ||
| } else if (typeof execScript !== "undefined") { | ||
| if (typeof execScript !== "undefined" | ||
| /* "bad" IE */ && typeof attachEvent !== "undefined" && typeof addEventListener === "undefined") { |
There was a problem hiding this comment.
Please extract the IE Check into its own block/helper
// Check for IE =< 8
function isIE () {
return typeof ...
}There was a problem hiding this comment.
Move the helper above L5
addScript.js
Outdated
| report(error); | ||
| } | ||
|
|
||
| function report(error) { |
There was a problem hiding this comment.
Move the helper above L5
michael-ciniawsky
changed the title
michael-ciniawsky
approved these changes
Sep 28, 2017
addScript.js
Outdated
| @@ -3,22 +3,27 @@ | |||
| Author Tobias Koppers @sokra | |||
| */ | |||
| module.exports = function(src) { | |||
|
|
|||
There was a problem hiding this comment.
Final nitpick 🐤 No block padding here please 😛
0.7.1 breaks IE8, this commit takes it back
alexander-akait
approved these changes
Sep 28, 2017
This was referenced Apr 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.7.1 breaks IE8, this commit takes it back
Notabel Changes
Issues
Related #41