fix(addStyles): check if HTMLIFrameElement exist
#296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
requested review from
alexander-akait,
michael-ciniawsky and
joshwiens
michael-ciniawsky
changed the title
HTMLIFrameElement exist
What is Cobalt ( |
|
You have a list of supported features here http://cobalt.foo/development/reference/supported-features.html |
michael-ciniawsky
approved these changes
Jan 26, 2018
michael-ciniawsky
added
status: Approved
and removed
pr_action: Review
priority: 4 (important)
severity: 3 (broken)
labels
michael-ciniawsky
changed the title
HTMLIFrameElement existHTMLIFrameElement exist
This was referenced Jan 27, 2018
This was referenced Oct 4, 2019
This was referenced Nov 7, 2019
This was referenced Apr 1, 2020
This was referenced Apr 23, 2020
This was referenced May 4, 2020
Aprillion
reviewed
Jun 6, 2020
| @@ -30,7 +30,7 @@ var getElement = (function (fn) { | |||
| if (typeof memo[selector] === "undefined") { | |||
| var styleTarget = fn.call(this, selector); | |||
| // Special case to return head of iframe instead of iframe itself | |||
| if (styleTarget instanceof window.HTMLIFrameElement) { | |||
| if (window.HTMLIFrameElement && styleTarget instanceof window.HTMLIFrameElement) { | |||
There was a problem hiding this comment.
window is not defined in server side rendering :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix on some browser the fact that
window.HTMLIFrameElementdoesn't existDid you add tests for your changes?
Not relevant IHMO
If relevant, did you update the README?
Not relevant IHMO
Summary
Style-loader can be used with Cobalt browser (https://cobalt.foo)
Does this PR introduce a breaking change?
No
Other information
Thank for your work
Cobalt
(https://cobalt.foo)
I had some trouble to connect in https on their website with chrom{ium, e} but not with firefox