Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style-loader/useable: There is a need to be able to control the order of inserting styles. #326

Open
budarin opened this issue May 8, 2018 · 11 comments

Comments

@budarin
Copy link

budarin commented May 8, 2018

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
When call stylesheet.use() - styles added on to a page in order as they were added - one after previous

If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
React has a reverse order of calling the component (style.use() called into each component in our project) so there may be a conflict of style overrides.
Styles should be inserted in reversed order - one before previous

If this is a feature request, what is motivation or use case for changing the behavior?
there is no any other ability to control the insertion order of styles

Please mention other relevant information such as your webpack version, Node.js version and Operating System.
"webpack": "4.8.1",
"style-loader": "^0.21.0",
node: 10.0.0
OS: Windows Server 2008R2

@alexander-akait
Copy link
Member

@budarin I think it is out of scope style-loader, please create minimum reproducible repo with steps in readme (actual and expected behavior). Thanks!

@budarin
Copy link
Author

budarin commented May 9, 2018

Hi!

here it's repo, please try

I would prefer to add one parameter to use()/ref(0 method - direction (to add above or under the last style tag)

@budarin
Copy link
Author

budarin commented Jun 24, 2018

@evilebottnawi
I'm sorry, but is there any news?

@budarin
Copy link
Author

budarin commented Sep 26, 2018

Hi!
are there any solutions to this problem?

You can simply solve this problem with addin an empty stylesheet with an id and inserting new styles just after it (when insertAt='bottom' & order='reverse') and just add styles on the top of page's head (when insertAt='top' & order='reverse')

@budarin
Copy link
Author

budarin commented Dec 17, 2018

is there anyone here?

@alexander-akait
Copy link
Member

alexander-akait commented Dec 17, 2018

@budarin no right now, refactoring style-loader will be after holidays and we can solve this

@alexander-akait
Copy link
Member

Anyway feel free to send a PR with PoC for better communication and implementation

@budarin
Copy link
Author

budarin commented Dec 17, 2018

thanks for good news :)

@alexander-akait
Copy link
Member

I think we need new api for this case, let's do it for 2.0.0, anyway feel free to send a PR if you need this as soon as possible

@david-minaya
Copy link

Any news with this? I'm having the same problem

@alexander-akait
Copy link
Member

Feel free to send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants