Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stylelint v15 #323

Merged
merged 1 commit into from
Feb 18, 2023
Merged

feat: add stylelint v15 #323

merged 1 commit into from
Feb 18, 2023

Conversation

ricardogobbosouza
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza commented Feb 11, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Add support stylelint v15

Resolve #322

Breaking Changes

No

Additional Info

// https://github.com/stylelint/stylelint/blob/15.0.0/lib/index.js#L16
/** @typedef {import('stylelint').default} Stylelint */

In previous versions

// https://github.com/stylelint/stylelint/blob/14.16.1/lib/index.js#L16
/** @typedef {import('stylelint').PublicApi} Stylelint */

For this reason, manually defined

/** @typedef {{lint: (options: LinterOptions) => Promise<LinterResult>, formatters: { [k: string]: Formatter }}} Stylelint */

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (6f80f5e) compared to base (d9a850e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #323   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          256       256           
  Branches        50        50           
=========================================
  Hits           256       256           
Impacted Files Coverage Δ
src/getStylelint.js 100.00% <ø> (ø)
src/index.js 100.00% <ø> (ø)
src/linter.js 100.00% <ø> (ø)
src/options.js 100.00% <ø> (ø)
src/worker.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ricardogobbosouza ricardogobbosouza marked this pull request as ready for review February 16, 2023 13:04
@ricardogobbosouza ricardogobbosouza merged commit 8dc5881 into master Feb 18, 2023
@ricardogobbosouza ricardogobbosouza deleted the feat-stylelint-15 branch February 18, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support stylelint ^15.0.0
2 participants