This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
fix(index): don't pass compilation as an argument to UglifyJsPlugin.buildError
#201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
michael-ciniawsky
changed the title
UglifyJsPlugin.buildErrorcompilation as an argument to UglifyJsPlugin.buildError
michael-ciniawsky
requested review from
alexander-akait,
michael-ciniawsky and
joshwiens
|
A test with bad ECMAScript code would prevent a future regression of error reporting. |
alexander-akait
approved these changes
Jan 4, 2018
michael-ciniawsky
added
status: Approved
and removed
priority: 3 (required)
pr_action: Review
severity: 3 (broken)
status: Pending
labels
This was referenced Jan 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197