This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
perf: reduce memory usage #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there an outstanding issue tied to this? Before I approve I just want to make sure we tie it to the work reported. |
|
@TheLarkInn no issue, it is own metrics in our private projects. We speedup plugin (now we don't spend time on parse source maps everytime, because we need they only when error occurs), also don't use memory for this. |
alexander-akait
force-pushed
the
perf-reduce-memory-usage
branch
from
19331f5
to
e20d330
Compare
alexander-akait
commented
Apr 12, 2018
src/index.js
Outdated
| line, | ||
| column, | ||
| }); | ||
|
|
||
| if (original && original.source && original.source !== file && warningsFilter(original.source)) { | ||
| accWarnings.push(`${warning.replace(warningRegex, '')}[${requestShortener.shorten(original.source)}:${original.line},${original.column}]`); | ||
| } else { | ||
| accWarnings.push(`${warning.replace(warningRegex, '')}`); |
There was a problem hiding this comment.
Fix, when we don't have source map warnings not emitting 😕
alexander-akait
commented
Apr 12, 2018
| Array [ | ||
| "Error: main.27965655b499b10158f3.js from UglifyJs", | ||
| "Dropping unused variable a [./test/fixtures/entry.js:4,0]", | ||
| "Dropping unused variable c [./test/fixtures/entry.js:5,0]", |
There was a problem hiding this comment.
Fix error helper in tests. Now we can see all warnings in tests.
alexander-akait
force-pushed
the
perf-reduce-memory-usage
branch
2 times, most recently
from
ef0fe8b
to
88b6c07
Compare
alexander-akait
force-pushed
the
perf-reduce-memory-usage
branch
from
88b6c07
to
ea4b23c
Compare
joshwiens
approved these changes
Apr 18, 2018
|
@d3viant0ne need patch release 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create source map on each
fileand it is increase memory usage very very very lagre, but usingsourceMaponly for error. Let's createsourceMaponly when erros/warnings were throws.