Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

refactor: apply webpack-defaults #102

Merged
merged 1 commit into from
Dec 17, 2017
Merged

refactor: apply webpack-defaults #102

merged 1 commit into from
Dec 17, 2017

Conversation

michael-ciniawsky
Copy link
Member

@michael-ciniawsky michael-ciniawsky commented Dec 16, 2017 •
edited
Loading

Notable Changes

  • Apply webpack-defaults@next
  • Add tests

Commit Message Summary (CHANGELOG)

- Upgrades to `webpack-defaults@2.0.0`
- Drops support for `node =< v4.0.0`
- Sets the minimum `peerDependency` to `webpack >= 3.0.0`

BREAKING CHANGE: Sets `engines` to `"node": ">= 6.9.0 || >= 8.9.0"`
BREAKING CHANGE: Drops support for `webpack =< v2.0.0`

Issues

@michael-ciniawsky michael-ciniawsky added this to the 1.0.0 milestone Dec 16, 2017
@michael-ciniawsky michael-ciniawsky mentioned this pull request Dec 16, 2017
Closed
6 tasks
@michael-ciniawsky michael-ciniawsky self-assigned this Dec 16, 2017
joshwiens
joshwiens reviewed Dec 16, 2017
View reviewed changes
codecov.yml Outdated
@@ -0,0 +1,17 @@
codecov:
Copy link
Member

@joshwiens joshwiens Dec 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in Defaults but not released yet. This will limit the number of checks on PRs to just changes

codecov:
  branch: master

coverage:
  precision: 2
  round: down
  range: 70...100

  status:
    project: no
    patch: yes

comment: 'off'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of what's in that codecov config has evidently been deprecated / changed since last we looked at it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@michael-ciniawsky
Copy link
Member Author

@webpack-contrib/org-maintainers I will address #28 #65 #79 in a separate PR as it is a feature, so this should be ready for a v1.0.0-alpha release after review :)

@michael-ciniawsky
refactor: apply webpack-defaults
0e103c7 
- Upgrades to `webpack-defaults@2.0.0`
- Drops support for `node =< v4.0.0`
- Sets the minimum `peerDependency` to `webpack >= 3.0.0`

BREAKING CHANGE: Sets `engines` to `"node": ">= 6.9.0 || >= 8.9.0"`
BREAKING CHANGE: Drops support for `webpack =< v2.0.0`
@michael-ciniawsky
Copy link
Member Author

Updated the commit message body, will this be picked up by standard-version for the CHANGELOG generation ? 🙃

@joshwiens
Copy link
Member

No, it will only pick up the squashed commit message unless you do a rebase merge. I have avoided enabling those because commits = contribution = open collective points which could be perceived negatively if pull request were merged as rebase with 5 or 6 individual hashs

@joshwiens
Copy link
Member

I usually just paste the body in the original comment so it's easy to grab when it's merged.

@michael-ciniawsky
Copy link
Member Author

Besides some rare exceptions squash merge should definitely be default 👍, would pasting a summary in the squash merge description field be picked by standard-version in case it is needed (e.g for Majors) ?

@joshwiens
Copy link
Member

I stand corrected, it does pick up the commit message you changed.
screen shot 2017-12-16 at 3 10 26 am

@joshwiens joshwiens merged commit 073b588 into master Dec 17, 2017
@joshwiens joshwiens deleted the next branch December 17, 2017 06:52
@michael-ciniawsky michael-ciniawsky removed this from the 1.0.0 milestone Mar 3, 2018
This was referenced Mar 21, 2018
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshwiens joshwiens joshwiens approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

@michael-ciniawsky michael-ciniawsky

Labels
semver: Major status: Approved type: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-ciniawsky @joshwiens @alexander-akait