feat: pass loaderContext as 2nd parameter
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MiniGod
commented
Dec 13, 2019
| @@ -1,9 +1,8 @@ | |||
| function args(...args) { | |||
| function args(options) { | |||
There was a problem hiding this comment.
FYI: Without this change, the following test fails: loader › should call the function with the loader options with:
TypeError: Converting circular structure to JSON.
I.e. the loaderContext can't matched with a snapshot as it can't be serialized to JSON.
alexander-akait
previously approved these changes
Dec 13, 2019
|
@MiniGod good work, can you improve readme? |
MiniGod
force-pushed
the
loaderContext-as-2nd-parameter
branch
from
d6f5abd to
981a9b5
Compare
|
Done 👍 |
alexander-akait
approved these changes
Dec 13, 2019
|
Thanks! Release will be tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #46
Breaking Changes
Shouldn't be any (I wouldn't consider the change I had to do in
test/args.jsa breaking change).Additional Information
The tests are covering the two exact use-cases I mentioned in #46, i.e. it does not check that it is the actual loader context, but rather uses it. Hope that's good enough testing for this.