Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a non-default option to open the report with "Show content of concatenated modules" already enabled #321

Closed
lorenzos opened this issue Oct 9, 2019 · 5 comments

Comments

@lorenzos
Copy link
Contributor

lorenzos commented Oct 9, 2019

Webpack does concatenate nearly all my source modules (React components), therefore I always need to open the sidebar and check "Show content of concatenated modules" when analyzing my bundles.

I see there are good reason to not enable it by default, but it'd be great to have an opt-in flag in the options object to open the report with concatenated modules already shown.

@valscion
Copy link
Member

Hmm I'm not sure if that's worth the cost added by a new option and maintenance burden. I think it should always be an informed choice to show inaccurate information, so not adding it as an option would force people to always understand that the information they're seeing is indeed inaccurate.

The people writing the configuration can be different people to those who view the analysis, and that I'm worried about.

What do you think, @th0r?

@th0r
Copy link
Collaborator

th0r commented Oct 10, 2019

@valscion I wonder, maybe we can store such settings in localStorage? Won't it solve your problem @lorenzos?

@valscion
Copy link
Member

It could — that way the UI would remember your choice but you would've been the one to make that choice in the first place, not the one who wrote the configuration.

@lorenzos
Copy link
Contributor Author

@th0r Sure, it'll be ok for my use case.

@valscion
Copy link
Member

A PR to implement such localStorage option is welcome ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants