fix: add support for aliases starting with `/` (`options.alias`) #597

atinux · 2017-08-22T17:26:53Z

What kind of change does this PR introduce?

Improvement in alias handling

Did you add tests for your changes?

Of course

Summary

Hi :)

Thank you for this great webpack loader. Actually, we are using it a lot into nuxt.js.

We have an issue with the css-loader used into the vue files, we have a global webpack alias named ~ and it's used a lot to require file this way: import '~/assets/my-file.vue'

Actually, we are using css-loader with this configuration:

{
    loader: 'css-loader',
    options: {
      minimize: true,
      importLoaders: 1,
      sourceMap: true,
      alias: {
        '/static': join(this.options.srcDir, 'static'),
        '/assets': join(this.options.srcDir, 'assets')
      }
   }
}

So our users can do this into their CSS:

.logo {
  background: url('~/static/logo.png');
}
.logo-2 {
  background: url('/logo.png');
}

Before this PR, .logo background url is transformed to /static/logo.png and considered as an url not processed (even if it's starting by an alias), .logo-2 is not processed and that's perfect.

Aftet this PR, .logo is transformed as well and considered to be a relative path (since starting by a known alias) and .logo-2 is not changed 👍

Does this PR introduce a breaking change?

No breaking change

Related issue to nuxt.js repo: nuxt/nuxt#1435

jsf-clabot · 2017-08-22T17:27:04Z

All committers have signed the CLA.

alexander-akait

Good work! Thanks!

atinux · 2017-08-23T08:38:23Z

I believe it could be a minor change or patch since it's only a bug fix :)

yuchonghua · 2017-08-24T05:28:02Z

Very good support, probably when the merger can be released?
/ping @evilebottnawi

meiyuanbo · 2017-08-24T08:42:08Z

probably when the merger can be released?

alexander-akait · 2017-08-24T09:16:41Z

@michael-ciniawsky @d3viant0ne friendly ping, need review, thanks!

michael-ciniawsky · 2017-08-24T16:53:21Z

lib/processCss.js

@@ -83,6 +83,11 @@ var parserPlugin = postcss.plugin("css-loader-parser", function(options) {
 			exports[exportName] = replaceImportsInString(exports[exportName]);
 		});

+		function startByAlias(url) {


startsWithAlias => isAlias[ed]

I pushed a change to rename it to isAlias

michael-ciniawsky · 2017-08-24T17:01:59Z

Relabeled to 🏷 semver: Patch for now as I don't think this would be a breaking change, but anyone might chime in and correct me if I'm wrong 😛

alexander-akait · 2017-08-24T17:04:49Z

@michael-ciniawsky oh, yep, it is patch, just invalid choice semver

appinteractive · 2017-08-25T12:59:18Z

Can someone click on merge please? 👍

alexander-akait · 2017-08-25T13:05:39Z

@appinteractive need minimum 3 approved votes
@michael-ciniawsky @d3viant0ne friendly ping

HadiChen · 2017-08-25T14:10:08Z

Can someone click on merge please? 👍

codecov · 2017-08-25T15:52:53Z

Codecov Report

Merging #597 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
+ Coverage   98.91%   98.91%   +<.01%     
==========================================
  Files          10       10              
  Lines         367      369       +2     
  Branches       87       87              
==========================================
+ Hits          363      365       +2     
  Misses          4        4

Impacted Files	Coverage Δ
lib/loader.js	`100% <ø> (ø)`	⬆️
lib/processCss.js	`98.67% <100%> (+0.01%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16bdeb...4367442. Read the comment docs.

michael-ciniawsky

@atinux Thx

liambuchanan · 2017-08-30T17:41:05Z

Haven't done much digging yet as this is a sub-dependency for us, but it appears merging has introduced a bug as processCss is not being instantiated with a resolve method here https://github.com/webpack-contrib/css-loader/blob/master/lib/localsLoader.js#L18

git required by webpack-contrib/css-loader#597

Add support for alias starting with /

d29deee

atinux mentioned this pull request Aug 22, 2017

[css-loader] Problem with static files nuxt/nuxt#1435

Closed

alexander-akait added priority: 4 (important) pr_action: Review semver: Major severity: 3 (broken) type: Bug labels Aug 22, 2017

alexander-akait approved these changes Aug 22, 2017

View reviewed changes

alexander-akait requested review from michael-ciniawsky and joshwiens August 24, 2017 09:16

michael-ciniawsky changed the title ~~Add support for aliases starting with /~~ fix: add support for aliases starting with / (options.alias) Aug 24, 2017

michael-ciniawsky reviewed Aug 24, 2017

View reviewed changes

michael-ciniawsky added semver: Patch and removed semver: Major labels Aug 24, 2017

michael-ciniawsky added this to the 0.28.6 milestone Aug 24, 2017

startByAlias -> isAlias

4367442

michael-ciniawsky approved these changes Aug 25, 2017

View reviewed changes

michael-ciniawsky added pr_action: Merge ready status: Approved labels Aug 25, 2017

joshwiens approved these changes Aug 30, 2017

View reviewed changes

joshwiens merged commit 63567f2 into webpack-contrib:master Aug 30, 2017

michael-ciniawsky removed the pr_action: Merge ready label Aug 30, 2017

michael-ciniawsky modified the milestone: 0.28.6 Aug 30, 2017

michael-ciniawsky mentioned this pull request Aug 30, 2017

fix: pass resolver to localsLoader (options.alias) #601

Merged

dependabot-preview bot mentioned this pull request Mar 16, 2018

Bump css-loader from 0.28.4 to 0.28.11 nju33/qiow#231

Open

NE-SmallTown mentioned this pull request Jul 23, 2018

File won't be packed and no error tip when use absolute path in url() #750

Closed

clarkdo mentioned this pull request Aug 15, 2018

Assets does not compiled at nuxt-edge:latest nuxt/nuxt#3723

Closed

snyk-bot mentioned this pull request Aug 16, 2019

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 DriveClutch/sellpy-dockerfiles#4

Closed

snyk-bot mentioned this pull request Jan 8, 2020

[Snyk] Upgrade css-loader from 0.17.0 to 0.28.11 timscharfenort/kibana#3

Open

This was referenced Jan 22, 2020

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 anyulled/Learn-Redux-Starter-Files#1

Open

[Snyk] Upgrade css-loader from 0.24.0 to 0.28.11 anyulled/react-skeleton#2

Closed

This was referenced Feb 23, 2020

[Snyk] Upgrade css-loader from 0.26.4 to 0.28.11 saurabharch/stitch-examples#2

Open

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 saurabharch/guesstimate-app#3

Open

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 saurabharch/CodeGenius#2

Open

snyk-bot mentioned this pull request Mar 7, 2020

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 yowainwright/react-workshop#4

Closed

This was referenced Apr 2, 2020

[Snyk] Upgrade css-loader from 0.26.4 to 0.28.11 fiverr/rollout_dashboard#48

Open

[Snyk] Upgrade css-loader from 0.19.0 to 0.28.11 rangle/react-day-picker#2

Open

snyk-bot mentioned this pull request Apr 24, 2020

[Snyk] Upgrade css-loader from 0.16.0 to 0.28.11 walmartlabs/bolt-standard-flux#3

Open

This was referenced May 4, 2020

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 Barnstorm-Online/votetracker#1

Open

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 React-Junkie/react-coffee-and-friends#2

Open

shadow-shaman0209 pushed a commit to shadow-shaman0209/arsenal-force that referenced this pull request Oct 13, 2023

bumped to slim container (temp)

76723cb

git required by webpack-contrib/css-loader#597

KrisPeachyKen mentioned this pull request Jul 30, 2024

[Snyk] Upgrade css-loader from 0.18.0 to 0.28.11 KrisPeachyKen/ai#2

Open

superadmiral mentioned this pull request Jul 30, 2024

[Snyk] Upgrade css-loader from 0.18.0 to 0.28.11 superadmiral/ai#2

Open

YinghanFeng mentioned this pull request Aug 2, 2024

[Snyk] Upgrade css-loader from 0.9.1 to 0.28.11 YinghanFeng/deco-ide#1

Open

go-benchmark1 mentioned this pull request Aug 16, 2024

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 go-benchmark1/pome#1

Open

Vishesh7797 mentioned this pull request Oct 26, 2024

[Snyk] Upgrade css-loader from 0.26.4 to 0.28.11 Vishesh7797/Sorting-Visualizer#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add support for aliases starting with `/` (`options.alias`) #597

fix: add support for aliases starting with `/` (`options.alias`) #597

atinux commented Aug 22, 2017 •

edited

Loading

jsf-clabot commented Aug 22, 2017 •

edited

Loading

alexander-akait left a comment

atinux commented Aug 23, 2017

yuchonghua commented Aug 24, 2017

meiyuanbo commented Aug 24, 2017

alexander-akait commented Aug 24, 2017

michael-ciniawsky Aug 24, 2017

atinux Aug 25, 2017

michael-ciniawsky commented Aug 24, 2017

alexander-akait commented Aug 24, 2017

appinteractive commented Aug 25, 2017

alexander-akait commented Aug 25, 2017

HadiChen commented Aug 25, 2017 •

edited

Loading

codecov bot commented Aug 25, 2017 •

edited

Loading

michael-ciniawsky left a comment

liambuchanan commented Aug 30, 2017

fix: add support for aliases starting with / (options.alias) #597

fix: add support for aliases starting with / (options.alias) #597

Conversation

atinux commented Aug 22, 2017 • edited Loading

jsf-clabot commented Aug 22, 2017 • edited Loading

alexander-akait left a comment

Choose a reason for hiding this comment

atinux commented Aug 23, 2017

yuchonghua commented Aug 24, 2017

meiyuanbo commented Aug 24, 2017

alexander-akait commented Aug 24, 2017

michael-ciniawsky Aug 24, 2017

Choose a reason for hiding this comment

atinux Aug 25, 2017

Choose a reason for hiding this comment

michael-ciniawsky commented Aug 24, 2017

alexander-akait commented Aug 24, 2017

appinteractive commented Aug 25, 2017

alexander-akait commented Aug 25, 2017

HadiChen commented Aug 25, 2017 • edited Loading

codecov bot commented Aug 25, 2017 • edited Loading

Codecov Report

michael-ciniawsky left a comment

Choose a reason for hiding this comment

liambuchanan commented Aug 30, 2017

fix: add support for aliases starting with `/` (`options.alias`) #597

fix: add support for aliases starting with `/` (`options.alias`) #597

atinux commented Aug 22, 2017 •

edited

Loading

jsf-clabot commented Aug 22, 2017 •

edited

Loading

HadiChen commented Aug 25, 2017 •

edited

Loading

codecov bot commented Aug 25, 2017 •

edited

Loading