fix: String not being base64 encoded

[tomcraven]

Bugfix for strings not being base64 encoded. The specific issue is to do with happypack passing SVGs as strings instead of Buffers causes them to not be encoded properly.

[jsf-clabot]

All committers have signed the CLA.

[michael-ciniawsky]

@tomcraven Thx in advance 😛 Could you elaborate on this futher please, is this happypack specific or a general issue ? If in general I will include this fix in #70 or you rebase the PR after #70 lands

[tomcraven]

hey @michael-ciniawsky thanks for the reply. The issue we were seeing is as follows:

• we want to use happypack with SVGs and the url-loader
• happypack passes the SVG content as a string to url-loader
• url-loader calls toString("base64") on this string variable
• calling toString("base64") on a string does not do any base64 conversion

So the issue seems specific to the happypack/url-loader interaction but, as with any untyped language, it would be great to be reactive to this way of passing in the SVG data

[michael-ciniawsky]

@tomcraven Could you please give a small code example just to clearify this definitely belongs here

[tomcraven]

hey @michael-ciniawsky, no problem. A little tricky to provide a code example that's small and also includes all the happypack/svg interaction. Here's a code example of what happens to the base64 encoding if the content is passed in as a string:

$ node
>
> "abc".toString("base64")
'abc'
> new Buffer("abc").toString("base64")
'YWJj'

No base 64 conversion happens on strings, it only happens if the object is a Buffer.

[michael-ciniawsky]

@tomcraven Could you please quickly rebase ? :)

[tomcraven]

hmm, that was my attempt at a rebase, let me know if you needed something else doing

[michael-ciniawsky]

@tomcraven Thx