Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove dist folder from being included on github #213

Closed
evenstensberg opened this issue Dec 15, 2017 · 4 comments
Closed

[BUG] Remove dist folder from being included on github #213

evenstensberg opened this issue Dec 15, 2017 · 4 comments
Labels
Good First Contribution Help Wanted

Comments

@evenstensberg
Copy link
Member

Do you want to request a feature or report a bug?

What is the current behavior?
Right now we are committing the dist folder on github.
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
We should remove it from being included, i.e .gitignore
If this is a feature request, what is motivation or use case for changing the behavior?

Please mention other relevant information such as the browser version, Node.js version, Operating System and programming language.
@evenstensberg
Copy link
Member Author

@kingdaro interested?

@itsMapleLeaf
Copy link
Contributor

No problem, I'll go ahead and knock this one out.

@itsMapleLeaf
Copy link
Contributor

Should I just commit this one to master? @ev1stensberg

@evenstensberg
Copy link
Member Author

Yep, this one could

@itsMapleLeaf itsMapleLeaf mentioned this issue Dec 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Contribution Help Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evenstensberg @itsMapleLeaf