Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --node-env flag #2388

Merged
merged 3 commits into from
Feb 2, 2021
Merged

feat: add --node-env flag #2388

merged 3 commits into from
Feb 2, 2021

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
YES WIP
If relevant, did you update the documentation?
YES
Summary
fixes #2362

Does this PR introduce a breaking change?
NO

Other information

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #2388 (eaf042b) into master (ad1a6b8) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2388      +/-   ##
==========================================
+ Coverage   71.74%   71.79%   +0.05%     
==========================================
  Files          47       47              
  Lines        2173     2177       +4     
  Branches      573      574       +1     
==========================================
+ Hits         1559     1563       +4     
  Misses        614      614              
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 91.92% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1a6b8...eaf042b. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need tests, anyway looks good

@alexander-akait
Copy link
Member

@snitin315 let's finish, I want to do release, it is very high requested feature

@snitin315
Copy link
Member Author

Need to fix CI, debugging.

alexander-akait
alexander-akait previously approved these changes Feb 2, 2021
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's convert from draft

@snitin315 snitin315 marked this pull request as ready for review February 2, 2021 13:18
@snitin315 snitin315 requested a review from a team as a code owner February 2, 2021 13:18
@alexander-akait
Copy link
Member

I will add some complex tests

@snitin315
Copy link
Member Author

💯

@alexander-akait alexander-akait merged commit e5126f1 into master Feb 2, 2021
@alexander-akait alexander-akait deleted the feat/node-env branch February 2, 2021 15:29
@alexander-akait
Copy link
Member

Thanks

This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NODE_ENV not set on process.env
3 participants