-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init command validations #315
Comments
Hi! I am new here and would like to contribute. Can I take a crack at this? |
@Symphoria We can surely do it together. ✌️ |
Got it. |
Completely agree:
|
Actually, I would propose to prompt to the user if it's ok to override the file. It's just for usability reasons, instead of having an error, delete the file and running the command again, we could do it for them! What do you think? |
Overriding the file with what value? Don't we just need a file to exist at the entry path specified? And why would we need to delete the entry file? |
Scenario is that people add the file later, so I don't know if we should support it. Makes sense to do |
I have mixed feeling about this. Usability wise it is nice to have. But if we do it, technically it will be a little bit cumbersome and will have one or two edge cases.
I would also like to have this approach in general and let the |
+1 |
Type: Feature/bug
What is the current behavior?
init
command, we ask for an entry path file as an input for scaffolding but we don't check if any file actually exists at that path."src/index"
instead of"./src/index"
which passes silently while scaffolding but causes errors at a later stage when webpack is executed.What is the expected behavior?
"./"
in cases when the input is"src/index"
. (Also validate path existence check after adding prefix)Steps to reproduce
Affected question
Which module will be the first to enter the application? [example: './src/index']
The text was updated successfully, but these errors were encountered: