-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: simplify logic, reduce extra loops and perf #3767
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
changed the title
Perf reduce loops
perf: simplify logic, reduce extra loops and perf
May 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3767 +/- ##
==========================================
- Coverage 91.64% 91.62% -0.02%
==========================================
Files 22 22
Lines 1627 1624 -3
Branches 460 463 +3
==========================================
- Hits 1491 1488 -3
Misses 136 136
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Avoid validation of our arguments from command line, i.e. when you havewebpack --stats invalid
Did you add tests for your changes?
Update existing
If relevant, did you update the documentation?
No need
Summary
Webpack always validates provided configurations, when we havewebpack --stats invalid
, we just setstats
to"invalid"
value and now try to validate it, but I don't see any reasons to spend time on it, because when we pass it towebpack
it will be validated again, so now we skip a one extra validationWe can't do it
Does this PR introduce a breaking change?
No
Other information
fixes #2626