fix: add client code for electron-renderer target (#1935)

webpack · May 29, 2019 · 9297988 · 9297988
1 parent bc83223
commit 9297988
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/utils/addEntries.js b/lib/utils/addEntries.js
@@ -72,6 +72,7 @@ function addEntries(config, options, server) {
       const webTarget =
         config.target === 'web' ||
         config.target === 'webworker' ||
+        config.target === 'electron-renderer' ||
         config.target == null;
       const additionalEntries = checkInject(
         options.injectClient,

diff --git a/test/Entry.test.js b/test/Entry.test.js
@@ -283,7 +283,8 @@ describe('Entry', () => {
       Object.assign({}, config),
       Object.assign({ target: 'web' }, config),
       Object.assign({ target: 'webworker' }, config),
-      Object.assign({ target: 'node' }, config) /* index:3 */,
+      Object.assign({ target: 'electron-renderer' }, config),
+      Object.assign({ target: 'node' }, config) /* index:4 */,
     ];
 
     const devServerOptions = {};
@@ -292,7 +293,7 @@ describe('Entry', () => {
 
     // eslint-disable-next-line no-shadow
     webpackOptions.forEach((webpackOptions, index) => {
-      const expectInline = index !== 3; /* all but the node target */
+      const expectInline = index !== 4; /* all but the node target */
 
       expect(webpackOptions.entry.length).toEqual(expectInline ? 2 : 1);