fix(examples/cli): correct template path in open-page example
#1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise is returning an _Html Webpack Plugin_ error: ``` Error: Child compilation failed: Entry module not found: Error: Can't resolve '/(...)/webpack/webpack-dev-server/examples/assets/layout.html ```
|
|
Codecov Report
@@ Coverage Diff @@
## master #1401 +/- ##
==========================================
+ Coverage 79.07% 79.14% +0.07%
==========================================
Files 6 6
Lines 497 494 -3
Branches 161 160 -1
==========================================
- Hits 393 391 -2
+ Misses 104 103 -1
Continue to review full report at Codecov.
|
michael-ciniawsky
approved these changes
Aug 15, 2018
michael-ciniawsky
changed the title
open-page exampleopen-page example
michael-ciniawsky
approved these changes
Aug 21, 2018
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise is returning an Html Webpack Plugin error:
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Trying to test the
--openbehaviour, first approach is to check the exampleand seems broken finding a wrong
path.Breaking Changes
Additional Info