Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page not reloading in iframe mode (inline: false) #1720

Closed
1 of 2 tasks
knagaitsev opened this issue Mar 16, 2019 · 5 comments
Closed
1 of 2 tasks

Page not reloading in iframe mode (inline: false) #1720

knagaitsev opened this issue Mar 16, 2019 · 5 comments

Comments

@knagaitsev
Copy link
Collaborator

  • Operating System: Windows 7
  • Node Version: 8.10.0
  • NPM Version: 6.4.1
  • webpack Version: 4.29.6
  • webpack-dev-server Version: 3.2.1
  • This is a bug
  • This is a modification request

Code

Expected Behavior

Page should reload in iframe mode on changes.

Actual Behavior

Page does not reload on changes (console output does not update).

For Bugs; How can we reproduce the behavior?

reproducible test repo: https://github.com/Loonride/webpack-dev-server-iframe
Do npm start, go to http://localhost:8080/webpack-dev-server/main.
Change something in src/index.js, the console output will not change and the message "App hot update." does not go away. Upon manual page refresh, the changes appear.

For Features; What is the motivation and/or use-case for the feature?

@smelukov smelukov self-assigned this Mar 17, 2020
@alexander-akait
Copy link
Member

/cc @smelukov Do you already start it?

@alexander-akait
Copy link
Member

@Loonride I think we should remove inline for next major release and remove inline client

@knagaitsev
Copy link
Collaborator Author

@Loonride I think we should remove inline for next major release and remove inline client

Yes I agree

@alexander-akait
Copy link
Member

So i think we can close the issue, it was always buggy and looks nobody uses it

@alexander-akait
Copy link
Member

/cc @Loonride I think we can close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants