Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(regression): always get necessary stats for hmr #1780

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

fixes #1776

Breaking Changes

No because previously behavior was wrong

Additional Info

No

@alexander-akait alexander-akait force-pushed the fix-regression-always-get-necessary-stats-for-hmr branch from 0b4dd62 to 8573b21 Compare April 9, 2019 17:25
@alexander-akait alexander-akait force-pushed the fix-regression-always-get-necessary-stats-for-hmr branch from 8573b21 to 6c939ce Compare April 9, 2019 17:27
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #1780 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1780      +/-   ##
==========================================
+ Coverage   87.62%   87.68%   +0.06%     
==========================================
  Files           9        9              
  Lines         590      593       +3     
  Branches      176      177       +1     
==========================================
+ Hits          517      520       +3     
  Misses         61       61              
  Partials       12       12
Impacted Files Coverage Δ
lib/Server.js 83.45% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028ceee...6c939ce. Read the comment docs.

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good, Thanks!

@hiroppy hiroppy merged commit 66b04a9 into master Apr 9, 2019
@hiroppy hiroppy deleted the fix-regression-always-get-necessary-stats-for-hmr branch April 9, 2019 18:32
@yoannmoinet
Copy link
Contributor

yoannmoinet commented Apr 16, 2019

Does that mean that we only respect warningsFilter from the options now?
Looks like it.

@alexander-akait
Copy link
Member Author

@yoannmoinet yep, unfortunately we don't have tests and it is invalid solution, if something need respect too feel free to open a issue or do a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashed in hot reload, version 3.3.0
3 participants