-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server): stricter headers security check #2092
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2092 +/- ##
==========================================
+ Coverage 94.45% 94.46% +<.01%
==========================================
Files 32 32
Lines 1208 1210 +2
Branches 333 334 +1
==========================================
+ Hits 1141 1143 +2
Misses 65 65
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarify and good job!
* fix(server): stricter headers security check * fix(server): changed comments explaining how server impl works
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Headers security check for connecting clients should not allow a connection without headers: #2077
Breaking Changes
Changes the socket server implementation requirements such that headers must be passed to
onConnection
callback.Additional Info