feat(options): add multiple openPage support
#2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitaljohn
requested review from
alexander-akait,
hiroppy and
knagaitsev
as code owners
|
|
|
Also please accept CLA |
Codecov Report
@@ Coverage Diff @@
## master #2266 +/- ##
==========================================
+ Coverage 93.9% 93.92% +0.01%
==========================================
Files 34 34
Lines 1280 1283 +3
Branches 368 369 +1
==========================================
+ Hits 1202 1205 +3
Misses 71 71
Partials 7 7
Continue to review full report at Codecov.
|
This was referenced Oct 1, 2019
digitaljohn
changed the title
openPage support
hiroppy
reviewed
Oct 1, 2019
alexander-akait
requested changes
Oct 2, 2019
|
@hiroppy @evilebottnawi any ideas on the failing tests? |
|
@digitaljohn sometimes chromeless failed on windows due unknown reason, so CI failed, don't worry |
rishabh3112
approved these changes
Oct 4, 2019
jamesgeorge007
approved these changes
Oct 5, 2019
digitaljohn
pushed a commit
to signal-noise/webpack-dev-server
that referenced
this pull request
Oct 7, 2019
This was referenced Dec 14, 2019
This was referenced Feb 22, 2020
This was referenced Mar 13, 2020
This was referenced Apr 4, 2020
This was referenced May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes and added an example.
Motivation / Use-Case
Closes issue #2265
Breaking Changes
No breaking changes
Additional Info
Added the ability to specify multiple windows to open using the existing
openPageoption. An array can now be set in thedevServerWebpack config object or if using the--open-pageCLI option a comma-delimited-list can be specified.API:
CLI: