-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow multiple paths in contentBasePublicPath #2489
feat: allow multiple paths in contentBasePublicPath #2489
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2489 +/- ##
==========================================
+ Coverage 93.53% 93.55% +0.02%
==========================================
Files 34 34
Lines 1314 1319 +5
Branches 375 379 +4
==========================================
+ Hits 1229 1234 +5
Misses 83 83
Partials 2 2
Continue to review full report at Codecov.
|
Can you provide real use case? |
When you have several micro applications which all have custom static folders: Application 1: |
@jleifeld just for information - you have one big app with own content static and multiple micro apps which used in on big app with own statics? |
Yes, that is the case. The main application is extendable with plugins. These plugins have all their own static folder. In our case we have these static folders:
This allows each plugin to have a scoped folder which does not get in conflict with other files from other plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change the CI code of lint asap. |
Need to update documentation. |
I will do it if you agree. |
@snitin315 Of course 👍 |
@hiroppy Feel free to merge after CI green |
Thanks |
For Bugs and Features; did you add new tests?
I add tests to verify that multiple contentBasePublicPath's are working.
Motivation / Use-Case
I need multiple static directories with different paths. The problem there is that there is no global root path for the assets.
Breaking Changes
This PR is free of breaking changes and provide downwards compatibility.
Additional Info