Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken historyApiFallback functionality in 2.1.0-beta.6 and later. #642

Closed
WillooWisp opened this issue Oct 7, 2016 · 2 comments
Closed

Comments

@WillooWisp
Copy link

I'm submitting a bug report

webpack: 2.1.0-beta.22
webpack-dev-server: 2.1.0-beta.2

Windows 10
Running server via CLI / Node.js API

Current behavior:
Refreshing browser with 404 error where it should fallback to index.html (using historyApiFallback) does fallback to a non-generated (unevaluated using html-webpack-plugin) index.html.

Expected/desired behavior:
It should fallback to a generated (evaluated using html-webpack-plugin) index.html file as it used to before 2.1.0-beta.6.

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem along with a gist/jsbin of your webpack configuration. Be sure to specify how you are running the server.
    Simply clone the angular2-webpack-starter, https://github.com/angularclass/angular2-webpack-starter.git and use npm run start:hmr. Navigate to any page and refresh browser.
  • What is the expected behavior?
    Redirect / fallback on 404 error to a correctly generated index.html file.
  • What is the motivation / use case for changing the behavior?
    It has worked before it was broken in 2.1.0-beta.6.
@WillooWisp WillooWisp changed the title I'm submitting a bug report for broken historyApiFallback functionality. Broken historyApiFallback functionality in 2.1.0-beta.6 and later. Oct 7, 2016
@Foxandxss
Copy link

I just reported it at #640 and I believe it is the same issue.

@SpaceK33z
Copy link
Member

Jep, it's the same issue. Thanks for the extra info though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants