Requests from Chrome WebView no longer detected as Chrome

[tednakamura]

5c5fff7 changed the Chrome detection logic from:

else if (navigator.webkitGetUserMedia)

to:

else if (navigator.webkitGetUserMedia && !!window.chrome)

Unfortunately, window.chrome is not present for WebView. This is mentioned in this Chromium bug report, but I think it's view restricted, so here's the relevant text:

is it expected that !!window.chrome returns false for WebView?
Checked webview m39 and trunk. Nope, window.chrome is not there for webview.

I'm hoping that reverting just that part of 5c5fff7 is enough to make WebView requests be detected as Chrome again, but I'm not certain.

Instructions to build WebView, and in particular the WebView shell app, are available here.

[fippo]

#132 is about the same thing. I think there are some additional issues to consider like CEF and nw.
Not sure why we don't use the existence of window.RTCPeerConnection... will take a stab next week.

[KaptenJansson]

I believe #122 is also the same issue.

[alvestrand]

WebView should be detected as WebView, not chrome, in my opinion. They build from the same base, but have some different properties. Should be quick to say "do like Chrome".

[fippo]

@alvestrand opera is detected as chrome. It behaves like chrome for peerconnection purposes but getusermedia is different (which influences how you display GUM hints).

But let's figure that out as a potential breaking change for 1.0