Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion position is wrong #209

Closed
darshanksexathought opened this issue Oct 15, 2020 · 0 comments · Fixed by #231
Closed

Suggestion position is wrong #209

darshanksexathought opened this issue Oct 15, 2020 · 0 comments · Fixed by #231

Comments

@darshanksexathought
Copy link

if (dropdownBottom > containerBounds.bottom) {
topPosition = top - dropdownBounds.height;
usedClasses.push(POSITION_CONFIGURATION.Y.TOP);
unusedClasses.push(POSITION_CONFIGURATION.Y.BOTTOM);
} else {
topPosition = top;
usedClasses.push(POSITION_CONFIGURATION.Y.BOTTOM);
unusedClasses.push(POSITION_CONFIGURATION.Y.TOP);
}

according to this code, it only checks if the suggestion is going out in the bottom you should also check if it is going out in the top because, if it goes out of the top then you will not see the first element unless you type the exact match, the good user behavior should be he can see the elements in the list from top not from the bottom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant